tools/clang/rewrite_scoped_refptr/tests/ref-to-local-returned-as-raw-expected.cc - Issue 1385193002: Bisect clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/rewrite_scoped_refptr/tests/ref-to-local-returned-as-raw-expected.cc

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: 246985 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/memory/ref_counted.h"

	6

	7 struct Foo : public base::RefCounted<Foo> {

	8 int dummy;

	9 };

	10

	11 // An example of an unsafe conversion, since the reference is bound to a

	12 // scoped_refptr with local storage. The tool should ignore this, since it

	13 // should prefer letting a human manually resolve trickier cases like this.

	14 Foo* TestFunction() {

	15 scoped_refptr<Foo> a;

	16 scoped_refptr<Foo>& b = a;

	17 return b;

	18 }

OLD	NEW