tools/clang/plugins/tests/weak_ptr_factory.txt - Issue 1385193002: Bisect clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/weak_ptr_factory.txt

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: 246985 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 weak_ptr_factory.cpp:54:38: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	2 base::WeakPtrFactory<FactoryFirst> factory_;

	3 ^

	4 weak_ptr_factory.cpp:60:39: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	5 base::WeakPtrFactory<FactoryMiddle> factory_;

	6 ^

	7 weak_ptr_factory.cpp:66:44: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	8 base::WeakPtrFactory<TwoFactoriesOneBad> factory1_;

	9 ^

	10 weak_ptr_factory.cpp:76:39: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	11 base::WeakPtrFactory<ClassTemplate> factory_;

	12 ^

	13 4 warnings generated.

OLD	NEW