Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: tools/clang/plugins/tests/base_refcounted.txt

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: 246985 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 In file included from base_refcounted.cpp:5:
2 ./base_refcounted.h:47:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
3 ~PublicRefCountedDtorInHeader() {}
4 ^
5 ./base_refcounted.h:44:7: note: [chromium-style] 'PublicRefCountedDtorInHeader' inherits from 'base::RefCounted<PublicRefCountedDtorInHeader>' here
6 : public base::RefCounted<PublicRefCountedDtorInHeader> {
7 ^
8 ./base_refcounted.h:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
9 ~PublicRefCountedThreadSafeDtorInHeader() {}
10 ^
11 ./base_refcounted.h:55:7: note: [chromium-style] 'PublicRefCountedThreadSafeDtor InHeader' inherits from 'base::RefCountedThreadSafe<PublicRefCountedThreadSafeDt orInHeader>' here
12 : public base::RefCountedThreadSafe<
13 ^
14 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual.
15 ~ProtectedRefCountedDtorInHeader() {}
16 ^
17 ./base_refcounted.h:110:3: warning: [chromium-style] Classes that are ref-counte d should have destructors that are declared protected or private.
18 ~DerivedProtectedToPublicInHeader() override {}
19 ^
20 ./base_refcounted.h:107:7: note: [chromium-style] 'DerivedProtectedToPublicInHea der' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
21 : public ProtectedRefCountedVirtualDtorInHeader {
22 ^
23 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here
24 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> {
25 ^
26 ./base_refcounted.h:115:7: warning: [chromium-style] Classes that are ref-counte d should have explicit destructors that are declared protected or private.
27 class ImplicitDerivedProtectedToPublicInHeader
28 ^
29 ./base_refcounted.h:116:7: note: [chromium-style] 'ImplicitDerivedProtectedToPub licInHeader' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
30 : public ProtectedRefCountedVirtualDtorInHeader {
31 ^
32 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here
33 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> {
34 ^
35 ./base_refcounted.h:145:1: warning: [chromium-style] Classes that are ref-counte d should have destructors that are declared protected or private.
36 class ImplementsAPublicInterface
37 ^
38 ./base_refcounted.h:147:7: note: [chromium-style] 'ImplementsAPublicInterface' i nherits from 'base::RefCounted<ImplementsAPublicInterface>' here
39 public base::RefCounted<ImplementsAPublicInterface> {
40 ^
41 ./base_refcounted.h:139:3: note: [chromium-style] Public destructor declared her e
42 virtual ~APublicInterface() {}
43 ^
44 ./base_refcounted.h:146:7: note: [chromium-style] 'ImplementsAPublicInterface' i nherits from 'APublicInterface' here
45 : public APublicInterface,
46 ^
47 ./base_refcounted.h:164:1: warning: [chromium-style] Classes that are ref-counte d should have explicit destructors that are declared protected or private.
48 class ImplementsAnImplicitInterface
49 ^
50 ./base_refcounted.h:166:7: note: [chromium-style] 'ImplementsAnImplicitInterface ' inherits from 'base::RefCounted<ImplementsAnImplicitInterface>' here
51 public base::RefCounted<ImplementsAnImplicitInterface> {
52 ^
53 ./base_refcounted.h:158:7: note: [chromium-style] No explicit destructor for 'An ImplicitInterface' defined
54 class AnImplicitInterface {
55 ^
56 ./base_refcounted.h:165:7: note: [chromium-style] 'ImplementsAnImplicitInterface ' inherits from 'AnImplicitInterface' here
57 : public AnImplicitInterface,
58 ^
59 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual.
60 ~RefcountedType() {}
61 ^
62 ./base_refcounted.h:204:3: warning: [chromium-style] Classes that are ref-counte d and have non-private destructors should declare their destructor virtual.
63 base_refcounted.cpp:16:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
64 ~AnonymousDerivedProtectedToPublicInImpl() override {}
65 ^
66 base_refcounted.cpp:13:7: note: [chromium-style] 'AnonymousDerivedProtectedToPub licInImpl' inherits from 'ProtectedRefCountedVirtualDtorInHeader' here
67 : public ProtectedRefCountedVirtualDtorInHeader {
68 ^
69 ./base_refcounted.h:81:7: note: [chromium-style] 'ProtectedRefCountedVirtualDtor InHeader' inherits from 'base::RefCounted<ProtectedRefCountedVirtualDtorInHeader >' here
70 : public base::RefCounted<ProtectedRefCountedVirtualDtorInHeader> {
71 ^
72 ./base_refcounted.h:73:3: warning: [chromium-style] Classes that are ref-counted and have non-private destructors should declare their destructor virtual.
73 ~ProtectedRefCountedDtorInHeader() {}
74 ^
75 base_refcounted.cpp:33:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
76 ~PublicRefCountedDtorInImpl() {}
77 ^
78 base_refcounted.cpp:30:7: note: [chromium-style] 'PublicRefCountedDtorInImpl' in herits from 'base::RefCounted<PublicRefCountedDtorInImpl>' here
79 : public base::RefCounted<PublicRefCountedDtorInImpl> {
80 ^
81 base_refcounted.cpp:59:3: warning: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private.
82 ~UnsafeTypedefChainInImpl() {}
83 ^
84 base_refcounted.cpp:56:34: note: [chromium-style] 'UnsafeTypedefChainInImpl' inh erits from 'Baz::MyLocalTypedef' (aka 'RefCounted<Foo::BarInterface>') here
85 class UnsafeTypedefChainInImpl : public Baz::MyLocalTypedef {
86 ^
87 13 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/plugins/tests/base_refcounted.flags ('k') | tools/clang/plugins/tests/blacklisted_dirs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698