tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.txt - Issue 1385193002: Bisect clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/weak_fields_require_tracing.txt

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: 246985 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 weak_fields_require_tracing.cpp:9:1: warning: [blink-gc] Class 'HeapObject' has untraced fields that require tracing.

	2 void HeapObject::trace(Visitor* visitor)

	3 ^

	4 ./weak_fields_require_tracing.h:17:5: note: [blink-gc] Untraced field 'm_obj1' d eclared here:

	5 Member<HeapObject> m_obj1;

	6 ^

	7 ./weak_fields_require_tracing.h:18:5: note: [blink-gc] Untraced field 'm_obj2' d eclared here:

	8 WeakMember<HeapObject> m_obj2;

	9 ^

	10 ./weak_fields_require_tracing.h:20:5: note: [blink-gc] Untraced field 'm_set1' d eclared here:

	11 HeapHashSet<WeakMember<HeapObject> > m_set1;

	12 ^

	13 1 warning generated.

OLD	NEW