Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385183002: Revert "Avoid eager enqueueing from resolution" (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Avoid eager enqueueing from resolution" This reverts commit dda38dfe47766b95abdbabe02b38c11010a694c4. BUG= Committed: https://github.com/dart-lang/sdk/commit/a0ca16a77361baa6e51a789471236e4e87167e18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -919 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 7 chunks +1 line, -267 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 12 chunks +46 lines, -97 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +1 line, -19 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 8 chunks +15 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 11 chunks +34 lines, -182 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 8 chunks +13 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 15 chunks +68 lines, -226 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 8 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/minimal_resolution_test.dart View 2 chunks +2 lines, -35 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 2 months ago (2015-10-06 12:35:59 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as a0ca16a77361baa6e51a789471236e4e87167e18 (presubmit successful).
5 years, 2 months ago (2015-10-06 12:36:32 UTC) #3
sigurdm
5 years, 2 months ago (2015-10-06 12:39:20 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698