Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: Source/WebKit/chromium/src/ChromeClientImpl.cpp

Issue 13851023: Remove ChromeClient cruft (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/src/ChromeClientImpl.h ('k') | Source/WebKit/chromium/src/WebPopupMenuImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/ChromeClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
index a0b2b9c84dad493ab1fb12b1a36a41acb3cb0ccc..6a10160fc247443f8a175bf51690cfb4be6d1558 100644
--- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp
+++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
@@ -240,10 +240,6 @@ void ChromeClientImpl::focusedNodeChanged(Node* node)
m_webView->client()->setKeyboardFocusURL(focusURL);
}
-void ChromeClientImpl::focusedFrameChanged(Frame*)
-{
-}
-
Page* ChromeClientImpl::createWindow(
Frame* frame, const FrameLoadRequest& r, const WindowFeatures& features, const NavigationAction& action)
{
@@ -479,12 +475,6 @@ void ChromeClientImpl::setStatusbarText(const String& message)
m_webView->client()->setStatusText(message);
}
-bool ChromeClientImpl::shouldInterruptJavaScript()
-{
- // FIXME: implement me
- return false;
-}
-
KeyboardUIMode ChromeClientImpl::keyboardUIMode()
{
return m_webView->tabsToLinks() ? KeyboardAccessTabsToLinks : KeyboardAccessDefault;
@@ -498,11 +488,6 @@ IntRect ChromeClientImpl::windowResizerRect() const
return result;
}
-void ChromeClientImpl::invalidateRootView(const IntRect&)
-{
- notImplemented();
-}
-
void ChromeClientImpl::invalidateContentsAndRootView(const IntRect& updateRect)
{
if (updateRect.isEmpty())
@@ -703,21 +688,6 @@ void ChromeClientImpl::print(Frame* frame)
m_webView->client()->printPage(WebFrameImpl::fromFrame(frame));
}
-void ChromeClientImpl::exceededDatabaseQuota(Frame* frame, const String& databaseName, DatabaseDetails)
-{
- // Chromium users cannot currently change the default quota
-}
-
-void ChromeClientImpl::reachedMaxAppCacheSize(int64_t spaceNeeded)
-{
- ASSERT_NOT_REACHED();
-}
-
-void ChromeClientImpl::reachedApplicationCacheOriginQuota(SecurityOrigin*, int64_t)
-{
- ASSERT_NOT_REACHED();
-}
-
#if ENABLE(INPUT_TYPE_COLOR)
PassOwnPtr<ColorChooser> ChromeClientImpl::createColorChooser(ColorChooserClient* chooserClient, const Color&)
{
@@ -989,11 +959,6 @@ ChromeClient::CompositingTriggerFlags ChromeClientImpl::allowedCompositingTrigge
return flags;
}
-bool ChromeClientImpl::supportsFullscreenForNode(const Node* node)
-{
- return false;
-}
-
void ChromeClientImpl::enterFullscreenForNode(Node* node)
{
ASSERT_NOT_REACHED();
@@ -1004,11 +969,6 @@ void ChromeClientImpl::exitFullscreenForNode(Node* node)
ASSERT_NOT_REACHED();
}
-bool ChromeClientImpl::supportsFullScreenForElement(const Element* element, bool withKeyboard)
-{
- return true;
-}
-
void ChromeClientImpl::enterFullScreenForElement(Element* element)
{
m_webView->enterFullScreenForElement(element);
@@ -1019,21 +979,6 @@ void ChromeClientImpl::exitFullScreenForElement(Element* element)
m_webView->exitFullScreenForElement(element);
}
-void ChromeClientImpl::fullScreenRendererChanged(RenderBox*)
-{
- notImplemented();
-}
-
-bool ChromeClientImpl::selectItemWritingDirectionIsNatural()
-{
- return false;
-}
-
-bool ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection()
-{
- return true;
-}
-
bool ChromeClientImpl::hasOpenedPopup() const
{
return m_webView->hasOpenedPopup();
@@ -1138,12 +1083,6 @@ void ChromeClientImpl::numWheelEventHandlersChanged(unsigned numberOfWheelHandle
m_webView->numberOfWheelEventHandlersChanged(numberOfWheelHandlers);
}
-bool ChromeClientImpl::shouldAutoscrollForDragAndDrop(WebCore::RenderBox*) const
-{
- return true;
-}
-
-
void ChromeClientImpl::needTouchEvents(bool needsTouchEvents)
{
m_webView->hasTouchEventHandlers(needsTouchEvents);
@@ -1182,11 +1121,6 @@ void ChromeClientImpl::didAssociateFormControls(const Vector<RefPtr<Element> >&
m_webView->autofillClient()->didAssociateFormControls(elementVector);
}
-bool ChromeClientImpl::shouldNotifyOnFormChanges()
-{
- return true;
-}
-
#if ENABLE(NAVIGATOR_CONTENT_UTILS)
PassOwnPtr<NavigatorContentUtilsClientImpl> NavigatorContentUtilsClientImpl::create(WebViewImpl* webView)
{
« no previous file with comments | « Source/WebKit/chromium/src/ChromeClientImpl.h ('k') | Source/WebKit/chromium/src/WebPopupMenuImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698