Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13851012: Absolutify paths in core/storage. (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, aandrey+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, kinuko, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, haraken, Nate Chapin
Visibility:
Public.

Description

Absolutify paths in core/storage. BUG=234793 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149012

Patch Set 1 #

Patch Set 2 : bindings #

Patch Set 3 : comment #

Patch Set 4 : ... #

Total comments: 1

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -36 lines) Patch
M Source/WebKit/chromium/src/StorageAreaProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/StorageAreaProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/StorageNamespaceProxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8DOMWindowCustom.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gyp/core.gyp View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/PageGroup.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/Storage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/Storage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/StorageEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Some unrelated-looking header moves are caused by me using a (slightly hacked-up) tools/sort-headers.py.
7 years, 8 months ago (2013-04-23 23:21:19 UTC) #1
abarth-chromium
Oh noes! I wrote a script to do this too.
7 years, 8 months ago (2013-04-23 23:30:21 UTC) #2
abarth-chromium
https://chromium.googlesource.com/chromium/blink/+/6fb64ab8c76c626bdc152b459370410bb167b583 My script changes all the #include lines in a directory rather than all the ...
7 years, 8 months ago (2013-04-23 23:31:52 UTC) #3
Nico
Looks like your stuff didn't land yet – can I move ahead with mine then? ...
7 years, 8 months ago (2013-04-24 16:22:40 UTC) #4
abarth-chromium
Go for it.
7 years, 8 months ago (2013-04-24 16:23:50 UTC) #5
abarth-chromium
LGTM https://codereview.chromium.org/13851012/diff/7001/Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.h File Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.h (right): https://codereview.chromium.org/13851012/diff/7001/Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.h#newcode42 Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.h:42: #include <wtf/Threading.h> Would you be willing to convert ...
7 years, 8 months ago (2013-04-24 16:25:47 UTC) #6
Nico
7 years, 8 months ago (2013-04-24 16:48:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as r149012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698