Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1385053002: content: Remove kDumpRenderTree variable. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
Avi (use Gerrit), ojan
CC:
ojan, asanka, benjhayden+dwatch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jochen (gone - plz use gerrit), mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Remove kDumpRenderTree variable. I forgot to remove it from the header file when I did https://chromium.googlesource.com/chromium/src/+/2eb4a6be7b92c44bfeee2cb69ad118d7cb8e44fa BUG=453252 R=ojan@chromium.org TBR=avi@chromium.org Committed: https://crrev.com/981b371bf42e3f5d53f3c06b272d974cb11c7f1f Cr-Commit-Position: refs/heads/master@{#352495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/common/shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
5 years, 2 months ago (2015-10-05 20:53:06 UTC) #1
ojan
lgtm
5 years, 2 months ago (2015-10-06 00:26:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385053002/1
5 years, 2 months ago (2015-10-06 00:28:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/106908)
5 years, 2 months ago (2015-10-06 00:41:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385053002/1
5 years, 2 months ago (2015-10-06 00:49:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 00:55:49 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/981b371bf42e3f5d53f3c06b272d974cb11c7f1f Cr-Commit-Position: refs/heads/master@{#352495}
5 years, 2 months ago (2015-10-06 00:56:39 UTC) #11
Avi (use Gerrit)
5 years, 2 months ago (2015-10-06 15:01:33 UTC) #12
Message was sent while issue was closed.
On 2015/10/06 00:56:39, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/981b371bf42e3f5d53f3c06b272d974cb11c7f1f
> Cr-Commit-Position: refs/heads/master@{#352495}

I am always up for removal of dead code....

wait...

I am always down for removal of dead code...

I can't decide o_O

lgtm

Powered by Google App Engine
This is Rietveld 408576698