Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3044)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 1385043002: cc: Remove SetLayerTreeHostClientReady() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startcomp
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 3d47528b9bc61b72f4d7a0e1164609cee66cbb27..4917e774abd902860a6b48b6fcbe7a70fffb0d69 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -172,6 +172,7 @@ class LayerTreeHostImplTest : public testing::Test,
output_surface_ = output_surface.Pass();
bool init = host_impl_->InitializeRenderer(output_surface_.get());
host_impl_->SetViewportSize(gfx::Size(10, 10));
+ host_impl_->SetVisible(true);
host_impl_->active_tree()->PushPageScaleFromMainThread(1.f, 1.f, 1.f);
// Set the BeginFrameArgs so that methods which use it are able to.
host_impl_->WillBeginImplFrame(CreateBeginFrameArgsForTesting(
@@ -6559,6 +6560,7 @@ class LayerTreeHostImplTestPrepareTiles : public LayerTreeHostImplTest {
&shared_bitmap_manager_, &task_graph_runner_);
host_impl_.reset(fake_host_impl_);
output_surface_ = CreateOutputSurface();
+ host_impl_->SetVisible(true);
host_impl_->InitializeRenderer(output_surface_.get());
host_impl_->SetViewportSize(gfx::Size(10, 10));
}
@@ -6567,6 +6569,9 @@ class LayerTreeHostImplTestPrepareTiles : public LayerTreeHostImplTest {
};
TEST_F(LayerTreeHostImplTestPrepareTiles, PrepareTilesWhenInvisible) {
+ EXPECT_TRUE(fake_host_impl_->prepare_tiles_needed());
+ // TODO: This is not really testing anything, since initializing the renderer
+ // dirties tile priorities.
no sievers 2015/10/05 19:51:10 @reveman: thoughts on this?
reveman 2015/10/06 00:46:05 we can fix this in a follow up if needed. maybe ju
no sievers 2015/10/06 19:39:47 Done.
fake_host_impl_->DidModifyTilePriorities();
EXPECT_TRUE(fake_host_impl_->prepare_tiles_needed());
fake_host_impl_->SetVisible(false);
« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698