Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 138503008: Speed up some mjsunit test cases and clean up test expectations for arm and mips. (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
CC:
v8-dev, Toon Verwaest
Visibility:
Public.

Description

Speed up some mjsunit test cases and clean up test expectations for arm and mips. Many skipped test cases already run very fast. Removing the corresponding expectations. BUG= R=jkummerow@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18812

Patch Set 1 #

Total comments: 1

Patch Set 2 : Speed up more tests and clean up expectations. #

Patch Set 3 : Speed up some tests by manually triggering GCs in debug versions of the tests. #

Patch Set 4 : Make use of disabling allocation inlining. #

Patch Set 5 : Remove useless calls in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -58 lines) Patch
A + test/mjsunit/compiler/alloc-number-debug.js View 1 2 3 4 2 chunks +8 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/regress-arguments.js View 3 chunks +15 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/regress-rep-change.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 3 chunks +11 lines, -40 lines 0 comments Download
M test/mjsunit/regress/regress-490.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-634-debug.js View 1 2 3 4 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Michael Achenbach
PTAL
6 years, 11 months ago (2014-01-15 10:41:54 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/138503008/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/138503008/diff/1/test/mjsunit/mjsunit.status#newcode132 test/mjsunit/mjsunit.status:132: 'compiler/alloc-number': [SKIP], We can hopefully do a similar ...
6 years, 11 months ago (2014-01-15 12:55:35 UTC) #2
Michael Achenbach
PTAL at patch 2
6 years, 11 months ago (2014-01-15 14:20:47 UTC) #3
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-15 14:31:42 UTC) #4
Michael Achenbach
PTAL at patch 3 [+mstarzinger]
6 years, 11 months ago (2014-01-15 15:47:35 UTC) #5
Michael Achenbach
ping
6 years, 11 months ago (2014-01-20 13:28:27 UTC) #6
mvstanton
lgtm. I chatted with MStarzinger too about the %SetAllocationTimeout call. This helper doesn't actually get ...
6 years, 11 months ago (2014-01-21 16:10:30 UTC) #7
Michael Achenbach
PTAL at patch 3. Ignore the rebase in mjsunit.status.
6 years, 11 months ago (2014-01-23 17:40:09 UTC) #8
Michael Achenbach
6 years, 11 months ago (2014-01-24 11:36:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 manually as r18812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698