Issue 138503007: Remove remoting.ClientPlugin interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138503007: Remove remoting.ClientPlugin interface (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov

Modified:
6 years, 11 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove remoting.ClientPlugin interface There was only one implementation of the ClientPlugin interface, and we don't have plans to add other implementations, so it doesn't make sense to have it as interface. Moved ClientPluginAsync to ClientPlugin. R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245086

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+521 lines, -723 lines)			Patch
M	remoting/remoting.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/webapp/all_js_load.gtestjs	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/webapp/client_plugin.js	View		12 chunks	+520 lines, -65 lines	0 comments	Download
D	remoting/webapp/client_plugin_async.js	View		1 chunk	+0 lines, -654 lines	0 comments	Download
M	remoting/webapp/client_session.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/webapp/main.html	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/138503007/40001

6 years, 11 months ago (2014-01-15 21:31:37 UTC) #3

Sergey Ulanov

6 years, 11 months ago (2014-01-16 03:18:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r245086 (presubmit successful).

Expand Messages | Collapse Messages