Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 138503002: Clean up ARM mov 32bit immediate code in preparation for out of line constant pool. (Closed)

Created:
6 years, 11 months ago by rmcilroy
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clean up ARM mov 32bit immediate code in preparation for out of line constant pool. R=rodolph.perfetta@arm.com, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19823

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -40 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +3 lines, -10 lines 0 comments Download
M src/arm/assembler-arm.cc View 5 chunks +19 lines, -27 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy
Part of the out-of-line constant pool change - PTAL.
6 years, 9 months ago (2014-03-07 18:51:12 UTC) #1
Rodolph Perfetta (ARM)
On 2014/03/07 18:51:12, rmcilroy wrote: > Part of the out-of-line constant pool change - PTAL. ...
6 years, 9 months ago (2014-03-10 15:28:11 UTC) #2
rmcilroy
On 2014/03/10 15:28:11, Rodolph Perfetta (ARM) wrote: > On 2014/03/07 18:51:12, rmcilroy wrote: > > ...
6 years, 9 months ago (2014-03-10 15:46:36 UTC) #3
Rodolph Perfetta (ARM)
lgtm
6 years, 9 months ago (2014-03-11 13:15:56 UTC) #4
ulan
lgtm
6 years, 9 months ago (2014-03-11 16:06:50 UTC) #5
rmcilroy
6 years, 9 months ago (2014-03-11 20:17:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r19823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698