Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1385023002: Disable VirtualAlloc randomization on 32-bit Windows hosts (Closed)

Created:
5 years, 2 months ago by jschuh
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable VirtualAlloc randomization on 32-bit Windows hosts ASLR is much weaker in a 2GB address space. Plus the vast majority of 32-bit Windows hosts are XP, which don't have ASLR anyway. So, avoid the fragmentation and skip it in this case. BUG=chromium:394591 LOG=Y R=jochen@chromium.org Committed: https://crrev.com/a15c5c96676738dac97f47e0f996b1ada9af3405 Cr-Commit-Position: refs/heads/master@{#31127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/base/platform/platform-win32.cc View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jschuh
PTAL. I have the following moral equivalent CL on the blink side: https://codereview.chromium.org/1383153002
5 years, 2 months ago (2015-10-05 19:06:26 UTC) #1
titzer
lgtm
5 years, 2 months ago (2015-10-06 16:31:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385023002/1
5 years, 2 months ago (2015-10-06 16:35:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 16:57:43 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 16:58:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a15c5c96676738dac97f47e0f996b1ada9af3405
Cr-Commit-Position: refs/heads/master@{#31127}

Powered by Google App Engine
This is Rietveld 408576698