Issue 13850004: Ignore symlinks in Drag-and-drop'ed folder

Issue 13850004: Ignore symlinks in Drag-and-drop'ed folder (Closed)

Created:
7 years, 8 months ago by kinuko

Modified:
7 years, 8 months ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore symlinks in Drag-and-drop'ed folder This patch also deprecate recursive enumeration support in IsolatedFileUtil as we no longer need it (http://crbug.com/176443) and adding symlink fix in the dead code doesn't sound productive. BUG=176443, 229849 TEST=IsolatedFileUtilTest.ReadDirectoryTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193413

Patch Set 1 #

Total comments: 2

Patch Set 2 : test symlinks only on POSIX #

Patch Set 3 : indent fix #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -59 lines)			Patch
	M	webkit/fileapi/isolated_file_util.cc	View		2 chunks	+7 lines, -58 lines	0 comments	Download
	M	webkit/fileapi/isolated_file_util_unittest.cc	View	1 2	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tzik

lgtm https://codereview.chromium.org/13850004/diff/1/webkit/fileapi/isolated_file_util_unittest.cc File webkit/fileapi/isolated_file_util_unittest.cc (right): https://codereview.chromium.org/13850004/diff/1/webkit/fileapi/isolated_file_util_unittest.cc#newcode391 webkit/fileapi/isolated_file_util_unittest.cc:391: file_util::CreateSymbolicLink( Add #ifdef for windows, (as we chatted)

7 years, 8 months ago (2013-04-10 13:10:22 UTC) #2

kinuko

Thx, updated. https://codereview.chromium.org/13850004/diff/1/webkit/fileapi/isolated_file_util_unittest.cc File webkit/fileapi/isolated_file_util_unittest.cc (right): https://codereview.chromium.org/13850004/diff/1/webkit/fileapi/isolated_file_util_unittest.cc#newcode391 webkit/fileapi/isolated_file_util_unittest.cc:391: file_util::CreateSymbolicLink( On 2013/04/10 13:10:22, tzik wrote: > ...

7 years, 8 months ago (2013-04-10 13:12:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/13850004/10002

7 years, 8 months ago (2013-04-10 13:30:11 UTC) #4

Message was sent while issue was closed.

Change committed as 193413

Expand Messages | Collapse Messages