Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1384983002: Revert of Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream (Closed)

Created:
5 years, 2 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream (patchset #3 id:40001 of https://codereview.chromium.org/1376313002/ ) Reason for revert: Seems to break some audio tests. See https://code.google.com/p/chromium/issues/detail?id=539362 Original issue's description: > Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream > > BUG= > TEST= > R=tommi@chromium.org,henrika@chromium.org,miu@chromium.org > > Committed: https://crrev.com/ca3ac60f80128160b38d099e0c319667cdc60719 > Cr-Commit-Position: refs/heads/master@{#352276} TBR=miu@chromium.org,tommi@chromium.org,ki.stfu@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0f59fe793596ee29f80a2fbcd1a0d06a1dc6a23b Cr-Commit-Position: refs/heads/master@{#352326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M media/audio/audio_manager_base.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream
5 years, 2 months ago (2015-10-05 14:51:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384983002/1
5 years, 2 months ago (2015-10-05 14:51:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 14:52:48 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:53:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f59fe793596ee29f80a2fbcd1a0d06a1dc6a23b
Cr-Commit-Position: refs/heads/master@{#352326}

Powered by Google App Engine
This is Rietveld 408576698