third_party/WebKit/LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt - Issue 1384973004: Forward assigning to style on HTMLElement, SVGElement and CSSStyleRule to style.cssText

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt

Issue 1384973004: Forward assigning to style on HTMLElement, SVGElement and CSSStyleRule to style.cssText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/setting-style-attribute-update-inline-style.html ('k') | third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1	1 FAIL e.width should be 16. Was 0.
	rune 2015/10/08 07:23:50 Why did this result change with your patch? I don' Why did this result change with your patch? I don't see style being set in that test. rune 2015/10/08 07:28:28 Also, if you think the new result is correct, you Show quoted text On 2015/10/08 07:23:50, rune wrote: > Why did this result change with your patch? I don't see style being set in that > test. Also, if you think the new result is correct, you should update the test to reflect that expecting 0 which should print a PASS. rune 2015/10/08 07:37:42 I was looking at the not-loaded case. I see now wh Show quoted text On 2015/10/08 07:28:28, rune wrote: > On 2015/10/08 07:23:50, rune wrote: > > Why did this result change with your patch? I don't see style being set in > that > > test. > > Also, if you think the new result is correct, you should update the test to > reflect that expecting 0 which should print a PASS. I was looking at the not-loaded case. I see now why it changed. The test didn't do what it said originally, since display:none was never set. You should make this a PASS, though. nainar 2015/10/08 22:22:43 Done. Done.
2 PASS e.width is 16

3 PASS e.height is 16	2 PASS e.height is 16

4 PASS successfullyParsed is true	3 PASS successfullyParsed is true

5	4

6 TEST COMPLETE	5 TEST COMPLETE

7	6

OLD	NEW