Cleanup of the metro viewer code

Cleanup of the metro viewer code

The main thing is the discovery of a clean way to retrieve the
corewindow hwnd based on ICoreWindowInterop, that removes some iffy
heuristic based on window name before.

From that we realize that we don't need some globals, namely the window
handle the thread id that owns the window.

BUG=151718
TEST=ash still works.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193120

[cpu_(ooo_6.6-7.5), 2013-04-09 00:16:21]

.

[robertshield, 2013-04-09 02:34:40]

Awesome, lgtm. As usual with your patches, reading it took a few minutes then
thirty minutes or so were spent reading blog posts and the like about the new
interfaces you dug up :-)

One question about additional opportunities for code deletion before commit:

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
File win8/metro_driver/chrome_app_view_ash.cc (left):

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
win8/metro_driver/chrome_app_view_ash.cc:542:
winrt_utils::FindCoreWindow(globals.main_thread_id, 10);
Do we still need the FindCoreWindow() function in winrt_utils.h? I think it's
only otherwise used in chrome_app_view.cc, could we do this same cleanup there?

[cpu_(ooo_6.6-7.5), 2013-04-09 02:39:54]

hehe I was afraid you were going to make me clean the 'legacy' path.

I rather not touch it, but if you feel strongly I can do so.


Mostly because I am not setup to test the old metro viewer, my machine is rigged
to test only ash :)

[cpu_(ooo_6.6-7.5), 2013-04-09 02:40:43]

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
File win8/metro_driver/chrome_app_view_ash.cc (left):

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
win8/metro_driver/chrome_app_view_ash.cc:542:
winrt_utils::FindCoreWindow(globals.main_thread_id, 10);
How did I miss this one?

On 2013/04/09 02:34:40, robertshield wrote:
> Do we still need the FindCoreWindow() function in winrt_utils.h? I think it's
> only otherwise used in chrome_app_view.cc, could we do this same cleanup
there?

[cpu_(ooo_6.6-7.5), 2013-04-09 02:41:38]

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
File win8/metro_driver/chrome_app_view_ash.cc (left):

https://codereview.chromium.org/13849005/diff/1/win8/metro_driver/chrome_app_...
win8/metro_driver/chrome_app_view_ash.cc:542:
winrt_utils::FindCoreWindow(globals.main_thread_id, 10);
Ah never mind.

On 2013/04/09 02:40:43, cpu wrote:
> How did I miss this one?
> 
> On 2013/04/09 02:34:40, robertshield wrote:
> > Do we still need the FindCoreWindow() function in winrt_utils.h? I think
it's
> > only otherwise used in chrome_app_view.cc, could we do this same cleanup
> there?
>

[robertshield, 2013-04-09 02:52:30]

On 2013/04/09 02:39:54, cpu wrote:
> hehe I was afraid you were going to make me clean the 'legacy' path.
> 
> I rather not touch it, but if you feel strongly I can do so.
>

But think of all the code that could be deleted :-) Strongly suggest doing so,
but if you really don't wanna, file a bug and I'll do it tomorrow morning on the
train (I have a non-aura checkout too).
 
> 
> Mostly because I am not setup to test the old metro viewer, my machine is
rigged
> to test only ash :)

[cpu_(ooo_6.6-7.5), 2013-04-09 17:02:53]

Committed patchset #2 manually as r193120 (presubmit successful).

[cpu_(ooo_6.6-7.5), 2013-04-09 17:04:01]

Ok, I'll let you do it. It is really mostly not being setup.

I'll do the code review :)