Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Side by Side Diff: fpdfsdk/include/javascript/JS_Runtime.h

Issue 1384883002: CJS_Timer should observe CJS_Runtime destruction. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 7 #ifndef FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 8 #define FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
9 9
10 #include <set> 10 #include <set>
11 #include <utility> 11 #include <utility>
12 12
13 #include "../../../core/include/fxcrt/fx_basic.h" 13 #include "../../../core/include/fxcrt/fx_basic.h"
14 #include "../jsapi/fxjs_v8.h" 14 #include "../jsapi/fxjs_v8.h"
15 #include "IJavaScript.h" 15 #include "IJavaScript.h"
16 #include "JS_EventHandler.h" 16 #include "JS_EventHandler.h"
17 17
18 class CJS_Context; 18 class CJS_Context;
19 19
20 class CJS_Runtime : public IFXJS_Runtime { 20 class CJS_Runtime : public IFXJS_Runtime {
21 public: 21 public:
22 class Observer {
23 public:
24 virtual void OnDestroyed() = 0;
25
26 protected:
27 virtual ~Observer() {}
28 };
29
22 using FieldEvent = std::pair<CFX_WideString, JS_EVENT_T>; 30 using FieldEvent = std::pair<CFX_WideString, JS_EVENT_T>;
23 31
24 explicit CJS_Runtime(CPDFDoc_Environment* pApp); 32 explicit CJS_Runtime(CPDFDoc_Environment* pApp);
25 ~CJS_Runtime() override; 33 ~CJS_Runtime() override;
26 34
27 // IFXJS_Runtime 35 // IFXJS_Runtime
28 IFXJS_Context* NewContext() override; 36 IFXJS_Context* NewContext() override;
29 void ReleaseContext(IFXJS_Context* pContext) override; 37 void ReleaseContext(IFXJS_Context* pContext) override;
30 IFXJS_Context* GetCurrentContext() override; 38 IFXJS_Context* GetCurrentContext() override;
31 void SetReaderDocument(CPDFSDK_Document* pReaderDoc) override; 39 void SetReaderDocument(CPDFSDK_Document* pReaderDoc) override;
32 CPDFSDK_Document* GetReaderDocument() override { return m_pDocument; } 40 CPDFSDK_Document* GetReaderDocument() override { return m_pDocument; }
33 41
34 CPDFDoc_Environment* GetReaderApp() const { return m_pApp; } 42 CPDFDoc_Environment* GetReaderApp() const { return m_pApp; }
35 43
36 // Returns true if the event isn't already found in the set. 44 // Returns true if the event isn't already found in the set.
37 bool AddEventToSet(const FieldEvent& event); 45 bool AddEventToSet(const FieldEvent& event);
38 void RemoveEventFromSet(const FieldEvent& event); 46 void RemoveEventFromSet(const FieldEvent& event);
39 47
40 void BeginBlock() { m_bBlocking = TRUE; } 48 void BeginBlock() { m_bBlocking = TRUE; }
41 void EndBlock() { m_bBlocking = FALSE; } 49 void EndBlock() { m_bBlocking = FALSE; }
42 FX_BOOL IsBlocking() const { return m_bBlocking; } 50 FX_BOOL IsBlocking() const { return m_bBlocking; }
43 51
44 v8::Isolate* GetIsolate() const { return m_isolate; } 52 v8::Isolate* GetIsolate() const { return m_isolate; }
45 v8::Local<v8::Context> NewJSContext(); 53 v8::Local<v8::Context> NewJSContext();
46 54
55 void AddObserver(Observer* observer);
56 void RemoveObserver(Observer* observer);
57
47 private: 58 private:
48 void DefineJSObjects(); 59 void DefineJSObjects();
49 60
50 CFX_ArrayTemplate<CJS_Context*> m_ContextArray; 61 CFX_ArrayTemplate<CJS_Context*> m_ContextArray;
51 CPDFDoc_Environment* m_pApp; 62 CPDFDoc_Environment* m_pApp;
52 CPDFSDK_Document* m_pDocument; 63 CPDFSDK_Document* m_pDocument;
53 FX_BOOL m_bBlocking; 64 FX_BOOL m_bBlocking;
54 std::set<FieldEvent> m_FieldEventSet; 65 std::set<FieldEvent> m_FieldEventSet;
55 v8::Isolate* m_isolate; 66 v8::Isolate* m_isolate;
56 bool m_isolateManaged; 67 bool m_isolateManaged;
57 v8::Global<v8::Context> m_context; 68 v8::Global<v8::Context> m_context;
69 std::set<Observer*> m_observers;
58 }; 70 };
59 71
60 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_ 72 #endif // FPDFSDK_INCLUDE_JAVASCRIPT_JS_RUNTIME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698