Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1384863002: Clarify WeakPtr threading characteristic. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, gavinp+memory_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify WeakPtr threading characteristic. Instances must exist, not only the factory, to enforce the thread check. An example fix this comment is relevant for: https://codereview.chromium.org/1389553002/ Committed: https://crrev.com/3ad03720b2c3186a681dbc1e0c0bbb6fb8aade24 Cr-Commit-Position: refs/heads/master@{#352445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M base/memory/weak_ptr.h View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scheib
5 years, 2 months ago (2015-10-04 04:35:08 UTC) #2
scheib
5 years, 2 months ago (2015-10-04 04:36:53 UTC) #4
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-05 15:47:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384863002/1
5 years, 2 months ago (2015-10-05 17:11:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 22:27:58 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:28:41 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ad03720b2c3186a681dbc1e0c0bbb6fb8aade24
Cr-Commit-Position: refs/heads/master@{#352445}

Powered by Google App Engine
This is Rietveld 408576698