add tool to track memory watermark

add tool to track memory watermark

R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/66db8a7f0ec197c742b182b674ca2784e57765b8

[Siggi Cherem (dart-lang), 2015-10-03 01:09:45]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-10-03 01:10:19]

sigmund@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-10-05 17:04:58]

lgtm

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
File pkg/compiler/tool/track_memory.dart (right):

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
pkg/compiler/tool/track_memory.dart:26: socket = await
WebSocket.connect('ws://localhost:8181/ws');
TODO: you might need to change the port if another VM has an active obseratory

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
pkg/compiler/tool/track_memory.dart:54: var isolate = await
_sendMessage('getIsolate', {'isolateId': isolateId});
Some strings are 'x' others "x".
I assume the intent is to be consistent with JSON but it is not entirely
consistent.

[Siggi Cherem (dart-lang), 2015-10-05 17:19:44]

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
File pkg/compiler/tool/track_memory.dart (right):

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
pkg/compiler/tool/track_memory.dart:26: socket = await
WebSocket.connect('ws://localhost:8181/ws');
On 2015/10/05 17:04:58, sra1 wrote:
> TODO: you might need to change the port if another VM has an active obseratory

Done. Just made it an arg which defaults to 8181

https://codereview.chromium.org/1384833002/diff/20001/pkg/compiler/tool/track...
pkg/compiler/tool/track_memory.dart:54: var isolate = await
_sendMessage('getIsolate', {'isolateId': isolateId});
On 2015/10/05 17:04:58, sra1 wrote:
> Some strings are 'x' others "x".
> I assume the intent is to be consistent with JSON but it is not entirely
> consistent.

Good point - yeah, I had started with ', then copied some samples that had " and
forgot to make it all the same. I went ahead and made them all '.

[Siggi Cherem (dart-lang), 2015-10-05 17:20:42]

Committed patchset #2 (id:40001) manually as
66db8a7f0ec197c742b182b674ca2784e57765b8 (presubmit successful).