Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/test/gpu/gpu_tests/gpu_rasterization.py

Issue 1384823002: Add "--test-type=gpu" to suppress API Keys InfoBar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/maps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_rasterization.py
diff --git a/content/test/gpu/gpu_tests/gpu_rasterization.py b/content/test/gpu/gpu_tests/gpu_rasterization.py
index 68f4e60113f01e48b86d5724c43302af540ba535..a2e5e83515c0449b76504ff2cc85721bb6d199e0 100644
--- a/content/test/gpu/gpu_tests/gpu_rasterization.py
+++ b/content/test/gpu/gpu_tests/gpu_rasterization.py
@@ -32,10 +32,13 @@ def _DidTestSucceed(tab):
class GpuRasterizationValidator(cloud_storage_test_base.ValidatorBase):
def CustomizeBrowserOptions(self, options):
+ # --test-type=gpu is used only to suppress the "Google API Keys are missing"
+ # infobar, which causes flakiness in tests.
options.AppendExtraBrowserArgs(['--enable-threaded-compositing',
'--enable-impl-side-painting',
'--force-gpu-rasterization',
- '--enable-gpu-benchmarking'])
+ '--enable-gpu-benchmarking',
+ '--test-type=gpu'])
def ValidateAndMeasurePage(self, page, tab, results):
if not _DidTestSucceed(tab):
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/maps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698