Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1384733002: [test] Protect against infinite loops in LiveRange logic. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Protect against infinite loops in LiveRange logic. A subset of the LiveRangeUnitTests (SplitInvalidPreStart, InvalidSplitEnd, SplitInvalidPostEnd) fail or hang on AIX in release mode. These tests fork a child which is expected to crash in register-allocator code after feeding in bad inputs. In debug mode, they behave as expected due to hitting a debug assert. In release mode, however, the tests rely only on the fact that dereferencing a null pointer will cause a SEGFAULT. This is true on most platforms, but not AIX. An AIX process has valid low memory pages mapped for reading and will not fault. Thus, these tests fail or hang because the child process survives the load from address zero and either completes (with undefined results) or goes into an infinite loop. R=bmeurer@chromium.org, danno@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4ddc9f1cc82f739f6da657e4076c291cbcdab765 Cr-Commit-Position: refs/heads/master@{#31090}

Patch Set 1 #

Patch Set 2 : disable tests in release mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M test/unittests/compiler/live-range-unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-02 16:21:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384733002/1
5 years, 2 months ago (2015-10-02 16:25:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 16:48:26 UTC) #5
Benedikt Meurer
I'd rather disable the test in release mode and leave the DCHECK as is, see ...
5 years, 2 months ago (2015-10-02 16:54:52 UTC) #6
MTBrandyberry
On 2015/10/02 16:54:52, Benedikt Meurer wrote: > I'd rather disable the test in release mode ...
5 years, 2 months ago (2015-10-02 17:33:43 UTC) #7
Benedikt Meurer
Nice, thanks. LGTM
5 years, 2 months ago (2015-10-02 18:13:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384733002/20001
5 years, 2 months ago (2015-10-02 18:21:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 18:44:58 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 18:45:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ddc9f1cc82f739f6da657e4076c291cbcdab765
Cr-Commit-Position: refs/heads/master@{#31090}

Powered by Google App Engine
This is Rietveld 408576698