Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 138473004: IndexedDB: Prevent terminated worker from hanging connections (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reword comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/indexeddb/IDBTransaction.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 138
139 // IDBDatabase's reference 139 // IDBDatabase's reference
140 EXPECT_EQ(1, transactionPtr->refCount()); 140 EXPECT_EQ(1, transactionPtr->refCount());
141 141
142 // Stop the context, so events don't get queued (which would keep the transa ction alive). 142 // Stop the context, so events don't get queued (which would keep the transa ction alive).
143 executionContext()->stopActiveDOMObjects(); 143 executionContext()->stopActiveDOMObjects();
144 144
145 // Fire an abort to make sure this doesn't free the transaction during use. The test 145 // Fire an abort to make sure this doesn't free the transaction during use. The test
146 // will not fail if it is, but ASAN would notice the error. 146 // will not fail if it is, but ASAN would notice the error.
147 db->onAbort(transactionId, DOMError::create(AbortError, "Aborted")); 147 db->onAbort(transactionId, DOMError::create(AbortError, "Aborted"));
148
149 // onAbort() should have cleared the transaction's reference to the database .
150 EXPECT_EQ(1, db->refCount());
148 } 151 }
149 152
150 } // namespace 153 } // namespace
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/IDBTransaction.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698