Issue 138473002: replace TestPixelRef with bitmap.allocPixels()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138473002: replace TestPixelRef with bitmap.allocPixels() (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
f(malita)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

replace TestPixelRef with bitmap.allocPixels() This is part of a larger effort to remove unnecessary subclass of pixelref from chrome/blink, to allow for faster evolution/iteration of bitmap/pixelref development in skia. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245171

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -52 lines)			Patch
	M	skia/ext/pixel_ref_utils_unittest.cc	View	1	2 chunks	+3 lines, -52 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

f(malita)

lgtm Can you add a note in the description on the motivation (TestPixelRef subclass not ...

6 years, 11 months ago (2014-01-14 17:07:31 UTC) #2

f(malita)

The debug failures look valid: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/12131/steps/unit_tests/logs/stdio

6 years, 11 months ago (2014-01-14 17:18:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/138473002/130001

6 years, 11 months ago (2014-01-15 14:04:01 UTC) #4

Message was sent while issue was closed.

Change committed as 245171

Expand Messages | Collapse Messages