Issue 1384673003: Fix FixedArrayBase cast in NumberOfOwnElements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1384673003: Fix FixedArrayBase cast in NumberOfOwnElements (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow

Modified:
5 years, 2 months ago

Reviewers:
Camillo Bruni

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix FixedArrayBase cast in NumberOfOwnElements The problem was harmless, but made --enable-slow-asserts unhappy. BUG=chromium:538086 LOG=n R=cbruni@chromium.org Committed: https://crrev.com/ecf232769150a8f3d561f8727892e714c40a2215 Cr-Commit-Position: refs/heads/master@{#31069}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/objects.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-538086.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384673003/1

5 years, 2 months ago (2015-10-02 11:22:14 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-02 11:49:09 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ecf232769150a8f3d561f8727892e714c40a2215
Cr-Commit-Position: refs/heads/master@{#31069}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages