Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h

Issue 1384663007: Fix regression in JBIG2 decoding from commit ce37d73. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/src/fxcodec/jbig2/JBig2_SddProc.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h
diff --git a/core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h b/core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h
index f31636b77cbc93a34c30d8fe77d9ceb940bf24cd..da9fa27ae3f0f7d7d2a14511a3c14959497a9b05 100644
--- a/core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h
+++ b/core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h
@@ -17,6 +17,8 @@ class CJBig2_ArithIntDecoder {
CJBig2_ArithIntDecoder();
~CJBig2_ArithIntDecoder();
+ // Returns true on success, and false when an OOB condition occurs. Many
+ // callers can tolerate OOB and does not check the return value.
Tom Sepez 2015/10/06 05:58:37 nit: do not
Lei Zhang 2015/10/06 06:01:23 Done.
bool decode(CJBig2_ArithDecoder* pArithDecoder, int* nResult);
private:
« no previous file with comments | « no previous file | core/src/fxcodec/jbig2/JBig2_SddProc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698