Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1384663004: [test] Mark test as failing on arm. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Mark test as failing on arm. BUG=v8:4459 LOG=n NOTRY=true NOTREECHECKS=true TBR=jkummerow@chromium.org Committed: https://crrev.com/9a43b521bea786ba234f391e99ede4be6f67f6ea Cr-Commit-Position: refs/heads/master@{#31077}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M test/intl/intl.status View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
Michael Achenbach
PTAL - not clear yet if it'll fail everywhere - therefore marked as pass/fail for ...
5 years, 2 months ago (2015-10-02 14:53:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663004/1
5 years, 2 months ago (2015-10-02 14:59:52 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-02 14:59:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663004/1
5 years, 2 months ago (2015-10-02 15:01:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 15:03:01 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a43b521bea786ba234f391e99ede4be6f67f6ea Cr-Commit-Position: refs/heads/master@{#31077}
5 years, 2 months ago (2015-10-02 15:03:45 UTC) #10
Jakob Kummerow
LGTM with an unimportant nit. https://codereview.chromium.org/1384663004/diff/1/test/intl/intl.status File test/intl/intl.status (right): https://codereview.chromium.org/1384663004/diff/1/test/intl/intl.status#newcode55 test/intl/intl.status:55: }], # 'arch == ...
5 years, 2 months ago (2015-10-02 15:45:31 UTC) #11
Michael Achenbach
5 years, 2 months ago (2015-10-05 10:26:15 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1384663004/diff/1/test/intl/intl.status
File test/intl/intl.status (right):

https://codereview.chromium.org/1384663004/diff/1/test/intl/intl.status#newco...
test/intl/intl.status:55: }],  # 'arch == arm64'
On 2015/10/02 15:45:31, Jakob wrote:
> nit: comment doesn't match original condition

yea - maybe not really worth having a CL for fixing that - I might include a fix
when I skip a test next time...

Powered by Google App Engine
This is Rietveld 408576698