Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_hover.dart

Issue 1384583007: Fix hover documentation for parameters. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/computer_hover.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart
index c09668b73937075f70b217a00996969bfb677548..8d870c099efe51484d03ac38edee23296c778c04 100644
--- a/pkg/analysis_server/lib/src/computer/computer_hover.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart
@@ -111,9 +111,7 @@ class DartUnitHoverComputer {
}
}
// documentation
- String dartDoc = element.computeDocumentationComment();
- dartDoc = _removeDartDocDelimiters(dartDoc);
- hover.dartdoc = dartDoc;
+ hover.dartdoc = _computeDocumentation(element);
}
// parameter
hover.parameter = _safeToString(expression.bestParameterElement);
@@ -127,5 +125,13 @@ class DartUnitHoverComputer {
return null;
}
+ String _computeDocumentation(Element element) {
+ if (element is ParameterElement) {
+ element = element.enclosingElement;
+ }
+ String dartDoc = element.computeDocumentationComment();
+ return _removeDartDocDelimiters(dartDoc);
+ }
+
static _safeToString(obj) => obj != null ? obj.toString() : null;
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698