Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1384583006: PPAPI regression test for NaCl x86-32 IRT stack alignment sensitivity (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
bbudge, Derek Schuff
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI regression test for NaCl x86-32 IRT stack alignment sensitivity The bug with IRT stack alignment sensitivity can manifest in two ways. The issue of the stack being aligned properly at callbacks from the IRT is tested on the NaCl side (irt_stack_alignment test). The other issue is alignment-sensitive SSE instructions being used to copy 16-byte arguments from the stack, assuming they will be properly aligned on the stack. That situation only comes up with the PPAPI interfaces that use a 16-byte argument type such as PP_Var. So test that case here. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3935 TEST= browser_tests --gtest_filter=PPAPINaClNewlibTest.NaClIRTStackAlignment on x86-32 R=bbudge@chromium.org, dschuff@chromium.org Committed: https://crrev.com/892faf25eff4691860da127aab8b71c0bcdfa3b9 Cr-Commit-Position: refs/heads/master@{#352146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -3 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/tests/test_nacl_irt_stack_alignment.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ppapi/tests/test_nacl_irt_stack_alignment.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Roland McGrath
5 years, 2 months ago (2015-10-02 20:42:39 UTC) #1
bbudge
LGTM
5 years, 2 months ago (2015-10-02 20:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384583006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384583006/1
5 years, 2 months ago (2015-10-02 21:14:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 21:54:49 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 21:56:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/892faf25eff4691860da127aab8b71c0bcdfa3b9
Cr-Commit-Position: refs/heads/master@{#352146}

Powered by Google App Engine
This is Rietveld 408576698