Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1384533003: Revert of ChromeOS: fix user signin by alias. (Closed)

Created:
5 years, 2 months ago by afakhry
Modified:
5 years, 2 months ago
CC:
dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS: fix user signin by alias. (patchset #4 id:60001 of https://codereview.chromium.org/1370913002/ ) Reason for revert: This Cl is causing the test login_OwnershipNotRetaken to fail on ChromePFQ. https://code.google.com/p/chromium/issues/detail?id=537986. Original issue's description: > THis CL fixes the issue with login using alternative e-mails. > > BUG=535369 > TEST=manual > > Committed: https://crrev.com/0f37b696b7a814d4157401c304643594a4ae9731 > Cr-Commit-Position: refs/heads/master@{#351482} TBR=achuith@chromium.org,alemate@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535369 Committed: https://crrev.com/98cd63d38fff2091a4ceda9130d93e41162bf1f5 Cr-Commit-Position: refs/heads/master@{#351886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -63 lines) Patch
M chrome/browser/chromeos/login/signin/device_id_browsertest.cc View 8 chunks +7 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 3 chunks +2 lines, -28 lines 0 comments Download
M components/user_manager/user_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
afakhry
Created Revert of ChromeOS: fix user signin by alias.
5 years, 2 months ago (2015-10-01 21:14:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384533003/1
5 years, 2 months ago (2015-10-01 21:15:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 21:17:43 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/98cd63d38fff2091a4ceda9130d93e41162bf1f5 Cr-Commit-Position: refs/heads/master@{#351886}
5 years, 2 months ago (2015-10-01 21:19:13 UTC) #4
achuithb
5 years, 2 months ago (2015-10-01 21:23:18 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698