Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: pkg/compiler/lib/src/native/behavior.dart

Issue 1384523003: Refactor resolution of foreign calls. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_backend.dart ('k') | pkg/compiler/lib/src/native/enqueue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/behavior.dart
diff --git a/pkg/compiler/lib/src/native/behavior.dart b/pkg/compiler/lib/src/native/behavior.dart
index dfb2c600e3ba7087dab8a2a88a2204bb24917a08..1afdb5bf980fa3b349ffc1c8b1407665f419330b 100644
--- a/pkg/compiler/lib/src/native/behavior.dart
+++ b/pkg/compiler/lib/src/native/behavior.dart
@@ -520,7 +520,7 @@ class NativeBehavior {
NativeBehavior behavior,
Send jsBuiltinOrEmbeddedGlobalCall,
Compiler compiler,
- ResolverVisitor resolver,
+ ForeignResolver resolver,
{bool isBuiltin,
List<String> validTags}) {
// The first argument of a JS-embedded global call is a string encoding
@@ -586,7 +586,7 @@ class NativeBehavior {
static NativeBehavior ofJsBuiltinCall(Send jsBuiltinCall,
Compiler compiler,
- ResolverVisitor resolver) {
+ ForeignResolver resolver) {
NativeBehavior behavior = new NativeBehavior();
behavior.sideEffects.setTo(new SideEffects());
@@ -598,7 +598,7 @@ class NativeBehavior {
static NativeBehavior ofJsEmbeddedGlobalCall(Send jsEmbeddedGlobalCall,
Compiler compiler,
- ResolverVisitor resolver) {
+ ForeignResolver resolver) {
NativeBehavior behavior = new NativeBehavior();
// TODO(sra): Allow the use site to override these defaults.
// Embedded globals are usually pre-computed data structures or JavaScript
« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_backend.dart ('k') | pkg/compiler/lib/src/native/enqueue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698