Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1384523002: [Release] Removed not needed revert feature from merge_to_branch.py (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Release] Removed not needed revert feature from merge_to_branch.py This feature is no longer needed because of the autotag bot. NOTRY=true LOG=N R=machenbach@chromium.org Committed: https://crrev.com/7ccf444572d55b1cd1be92e4e71726ad3482b89e Cr-Commit-Position: refs/heads/master@{#31053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M tools/release/merge_to_branch.py View 9 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Hablich
Seems like this was not even covered by UnitTests despite that of line 1160 in ...
5 years, 2 months ago (2015-10-01 13:38:19 UTC) #1
Michael Achenbach
lgtm
5 years, 2 months ago (2015-10-01 14:16:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384523002/1
5 years, 2 months ago (2015-10-01 15:19:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 15:21:22 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 15:23:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ccf444572d55b1cd1be92e4e71726ad3482b89e
Cr-Commit-Position: refs/heads/master@{#31053}

Powered by Google App Engine
This is Rietveld 408576698