Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1384513002: Fix unix file permissions in resource zips and jar files (Closed)

Created:
5 years, 2 months ago by tsniatowski
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unix file permissions in resource zips and jar files https://codereview.chromium.org/1319623002 changed how zip files are created in the python helper and (accidentally?) made it set 000 unix file permissions for the archived files. Make it 644 so the zip files are not suprising to work with on Linux if anyone needs to look at them manually. BUG=523420 R=dpranke@chromium.org, agrieve@chromium.org, Committed: https://crrev.com/7f176175ed3c9aa94a796676ce68ed3628e5515b Cr-Commit-Position: refs/heads/master@{#351843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/gyp/util/build_utils.py View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tsniatowski
5 years, 2 months ago (2015-10-01 13:17:11 UTC) #2
agrieve
On 2015/10/01 13:17:11, tsniatowski wrote: lgtm
5 years, 2 months ago (2015-10-01 15:08:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384513002/1
5 years, 2 months ago (2015-10-01 16:32:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 18:11:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7f176175ed3c9aa94a796676ce68ed3628e5515b Cr-Commit-Position: refs/heads/master@{#351843}
5 years, 2 months ago (2015-10-01 18:12:32 UTC) #7
Dirk Pranke
5 years, 2 months ago (2015-10-01 18:52:08 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698