Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 13845023: Correctly set technology state to UNAVAILABLE (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Correctly set technology state to UNAVAILABLE BUG=232417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194975

Patch Set 1 #

Patch Set 2 : Add TexchnologyState unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -12 lines) Patch
M chromeos/dbus/shill_manager_client.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_manager_client_stub.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_manager_client_stub.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 1 6 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
7 years, 8 months ago (2013-04-18 15:42:56 UTC) #1
Ben Chan
On 2013/04/18 15:42:56, stevenjb (chromium) wrote: TEST=? or unit test? lgtm
7 years, 8 months ago (2013-04-18 15:55:54 UTC) #2
stevenjb
Good suggestion. Test added. PTAL.
7 years, 8 months ago (2013-04-18 16:55:04 UTC) #3
gauravsh
On 2013/04/18 16:55:04, stevenjb (chromium) wrote: > Good suggestion. Test added. PTAL. Also commit message ...
7 years, 8 months ago (2013-04-18 16:56:24 UTC) #4
stevenjb
On 2013/04/18 16:56:24, gauravsh wrote: > On 2013/04/18 16:55:04, stevenjb (chromium) wrote: > > Good ...
7 years, 8 months ago (2013-04-18 17:13:08 UTC) #5
stevenjb
7 years, 8 months ago (2013-04-18 18:36:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r194975 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698