Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm
index a9ecdfea28ccf020736b9b812154398de6b93b4e..3243d469c6dad8fdafa6efe270e654f4410244bc 100644
--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm
@@ -20,13 +20,18 @@ void PerformClose(OneClickSigninBubbleController* controller) {
 @implementation OneClickSigninBubbleController
 
 - (id)initWithBrowserWindowController:(BrowserWindowController*)controller
+                          webContents:(content::WebContents*)webContents
+                         errorMessage:(const string16&)errorMessage
                              callback:(const BrowserWindow::StartSyncCallback&)
-                                          syncCallback {
+                                                                    syncCallback{
   viewController_.reset([[OneClickSigninViewController alloc]
       initWithNibName:@"OneClickSigninBubble"
-          webContents:NULL
+          webContents:webContents
          syncCallback:syncCallback
-        closeCallback:base::Bind(PerformClose, self)]);
+        closeCallback:base::Bind(PerformClose, self)
+         isSyncDialog:false

[Alexei Svitkine (slow), 2013/04/19 19:54:15]

false -> NO

[noms (inactive), 2013/04/22 15:28:07]

Done.

+         errorMessage:errorMessage]);
+
   NSWindow* parentWindow = [controller window];
 
   // Set the anchor point to right below the wrench menu.
@@ -51,6 +56,8 @@ void PerformClose(OneClickSigninBubbleController* controller) {
     // -[BaseBubbleController windowWillClose:].
     [self retain];
   }
+
+

[Alexei Svitkine (slow), 2013/04/19 19:54:15]

Nit: Remove extra blank line. One blank line here is ok.

[noms (inactive), 2013/04/22 15:28:07]

Done.

   return self;
 }