chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h - Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble

Patch Set: Fix bot issues Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

index 2086f355a85633fa14c697316dcce9704eb639cc..a7f64d8139843e231857cc9698e3ca18decedf6c 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h

@@ -19,6 +19,8 @@

// has started).

@interface OneClickSigninBubbleController : BaseBubbleController {

scoped_nsobject<OneClickSigninViewController> viewController_;

+ @private

+ IBOutlet NSTextField* messageTextField_;

}

@property(readonly, nonatomic) OneClickSigninViewController* viewController;

@@ -30,6 +32,8 @@

// The bubble is not automatically displayed; call showWindow:id to

// display. The bubble is auto-released on close.

- (id)initWithBrowserWindowController:(BrowserWindowController*)controller

+ webContents:(content::WebContents*)webContents

+ errorMessage:(const string16&)errorMessage

Alexei Svitkine (slow) 2013/04/19 19:54:15 Please document the parameters, particularly |erro

noms (inactive) 2013/04/22 15:28:07 Done.

callback:(const BrowserWindow::StartSyncCallback&)

syncCallback;