Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: Source/devtools/front_end/SettingsScreen.js

Issue 13845021: DevTools: Bring Sass support from behind the experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/SettingsScreen.js
diff --git a/Source/devtools/front_end/SettingsScreen.js b/Source/devtools/front_end/SettingsScreen.js
index 904c1bf52d6d2c0693e632a022bd10153c085391..295324c14a71112a6fb10d73f76fbc930a5512ea 100644
--- a/Source/devtools/front_end/SettingsScreen.js
+++ b/Source/devtools/front_end/SettingsScreen.js
@@ -312,9 +312,14 @@ WebInspector.GenericSettingsTab = function()
p = this._appendSection(WebInspector.UIString("Sources"));
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Search in content scripts"), WebInspector.settings.searchInContentScripts));
- p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Enable source maps"), WebInspector.settings.sourceMapsEnabled));
- if (WebInspector.experimentsSettings.isEnabled("sass"))
- p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Auto-reload CSS upon Sass save"), WebInspector.settings.cssReloadEnabled));
+ p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Enable JS source maps"), WebInspector.settings.jsSourceMapsEnabled));
+ p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Enable CSS source maps"), WebInspector.settings.cssSourceMapsEnabled));
+ WebInspector.settings.cssSourceMapsEnabled.addChangeListener(this._cssSourceMapsEnablementChanged, this);
+ this._cssSourceMapSettings = p.createChild("fieldset");
+ var autoReloadCSSCheckbox = this._cssSourceMapSettings.createChild("input");
+ this._cssSourceMapSettings.appendChild(this._createCheckboxSetting(WebInspector.UIString("Auto-reload generated CSS"), WebInspector.settings.cssReloadEnabled, false, autoReloadCSSCheckbox));
+ this._cssSourceMapsEnablementChanged();
+
var indentationElement = this._createSelectSetting(WebInspector.UIString("Indentation"), [
[ WebInspector.UIString("Auto-detect"), WebInspector.TextUtils.Indent.AutoDetect ],
[ WebInspector.UIString("2 spaces"), WebInspector.TextUtils.Indent.TwoSpaces ],
@@ -378,6 +383,15 @@ WebInspector.GenericSettingsTab.prototype = {
},
/**
+ * @param {WebInspector.Event=} event
+ */
+ _cssSourceMapsEnablementChanged: function(event)
+ {
+ var cssSourceMapsEnabled = event ? /** @type {boolean} */ (event.data) : WebInspector.settings.cssSourceMapsEnabled.get();
+ this._cssSourceMapSettings.disabled = !cssSourceMapsEnabled;
+ },
+
+ /**
* @param {HTMLFieldSetElement} fieldset
*/
_timelineLimitStackFramesChanged: function(fieldset)
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698