Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: Source/devtools/front_end/SASSSourceMapping.js

Issue 13845021: DevTools: Bring Sass support from behind the experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/DebuggerScriptMapping.js ('k') | Source/devtools/front_end/Settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/SASSSourceMapping.js
diff --git a/Source/devtools/front_end/SASSSourceMapping.js b/Source/devtools/front_end/SASSSourceMapping.js
index 9964e67e58045877afad03c7fa9bc07d78c879a3..e2764ee4f16db0f5a34994af61347ba8bd67b5f7 100644
--- a/Source/devtools/front_end/SASSSourceMapping.js
+++ b/Source/devtools/front_end/SASSSourceMapping.js
@@ -46,6 +46,7 @@ WebInspector.SASSSourceMapping = function(cssModel, workspace, networkWorkspaceP
this._addingRevisionCounter = 0;
this._reset();
WebInspector.fileManager.addEventListener(WebInspector.FileManager.EventTypes.SavedURL, this._fileSaveFinished, this);
+ WebInspector.settings.cssSourceMapsEnabled.addChangeListener(this._toggleSourceMapSupport, this)
this._cssModel.addEventListener(WebInspector.CSSStyleModel.Events.StyleSheetChanged, this._styleSheetChanged, this);
this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this);
this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeContentCommitted, this._uiSourceCodeContentCommitted, this);
@@ -64,13 +65,25 @@ WebInspector.SASSSourceMapping.prototype = {
return;
}
var header = this._cssModel.styleSheetHeaderForId(id);
- if (!header || !WebInspector.experimentsSettings.sass.isEnabled())
+ if (!header)
return;
- var wasHeaderKnown = header.sourceURL && !!this._completeSourceMapURLForCSSURL[header.sourceURL];
this.removeHeader(header);
- if (wasHeaderKnown)
- header.updateLocations();
+ },
+
+ /**
+ * @param {WebInspector.Event} event
+ */
+ _toggleSourceMapSupport: function(event)
+ {
+ var enabled = /** @type {boolean} */ (event.data);
+ var headers = this._cssModel.styleSheetHeaders();
+ for (var i = 0; i < headers.length; ++i) {
+ if (enabled)
+ this.addHeader(headers[i]);
+ else
+ this.removeHeader(headers[i]);
+ }
},
/**
@@ -369,7 +382,7 @@ WebInspector.SASSSourceMapping.prototype = {
*/
addHeader: function(header)
{
- if (!header.sourceMapURL || !header.sourceURL || header.isInline || !WebInspector.experimentsSettings.sass.isEnabled())
+ if (!header.sourceMapURL || !header.sourceURL || header.isInline || !WebInspector.settings.cssSourceMapsEnabled.get())
return;
var completeSourceMapURL = WebInspector.ParsedURL.completeURL(header.sourceURL, header.sourceMapURL);
if (!completeSourceMapURL)
@@ -397,6 +410,7 @@ WebInspector.SASSSourceMapping.prototype = {
var completeSourceMapURL = WebInspector.ParsedURL.completeURL(sourceURL, header.sourceMapURL);
if (completeSourceMapURL)
delete this._sourceMapByURL[completeSourceMapURL];
+ header.updateLocations();
},
/**
« no previous file with comments | « Source/devtools/front_end/DebuggerScriptMapping.js ('k') | Source/devtools/front_end/Settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698