Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 13845020: Don't specify min/max bounds for v1 panels (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
Reviewers:
flackr, jeremya
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
I'm really not sure why I set these in the first place, I think maybe ...
7 years, 8 months ago (2013-04-18 15:20:31 UTC) #1
flackr
lgtm
7 years, 8 months ago (2013-04-18 15:30:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/13845020/1
7 years, 8 months ago (2013-04-18 15:43:41 UTC) #3
commit-bot: I haz the power
Presubmit check for 13845020-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-18 15:43:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/13845020/1
7 years, 8 months ago (2013-04-18 17:14:30 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 18:15:19 UTC) #6
stevenjb
7 years, 8 months ago (2013-04-18 18:34:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r194974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698