Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 13845017: ime: Implement the observer list for FakeInputMethod. (Closed)

Created:
7 years, 8 months ago by sadrul
Modified:
7 years, 8 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

ime: Implement the observer list for FakeInputMethod. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194365

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M ui/base/ime/fake_input_method.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/base/ime/fake_input_method.cc View 3 chunks +13 lines, -3 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc File ui/base/ime/fake_input_method.cc (right): https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc#newcode114 ui/base/ime/fake_input_method.cc:114: void FakeInputMethod::OnFocus() {} Is it necessary to trigger the ...
7 years, 8 months ago (2013-04-16 02:25:17 UTC) #1
Seigo Nonaka
lgtm https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc File ui/base/ime/fake_input_method.cc (right): https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc#newcode114 ui/base/ime/fake_input_method.cc:114: void FakeInputMethod::OnFocus() {} I think no as far ...
7 years, 8 months ago (2013-04-16 07:49:18 UTC) #2
sadrul
https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc File ui/base/ime/fake_input_method.cc (right): https://codereview.chromium.org/13845017/diff/1/ui/base/ime/fake_input_method.cc#newcode114 ui/base/ime/fake_input_method.cc:114: void FakeInputMethod::OnFocus() {} On 2013/04/16 07:49:18, Seigo Nonaka wrote: ...
7 years, 8 months ago (2013-04-16 15:14:55 UTC) #3
sadrul
7 years, 8 months ago (2013-04-16 15:15:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r194365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698