Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1384483004: PPC: [Interpreter] Add CallRuntime support to the interpreter. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Add CallRuntime support to the interpreter. Port 75f6ad74b2c0fe2e5dec7110d076d892cfbb6b69 Original commit message: Adds support for calling runtime functions from the interpreter. Adds the CallRuntime bytecode which takes a Runtime::FunctionId of the function to call and the arguments in sequential registers. Adds a InterpreterCEntry builtin to enable the interpreter to enter C++ code based on the functionId. Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall and groups all the interpreter builtins together. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/f3f940f4358a09193d2869baf03cc88ddcc622bb Cr-Commit-Position: refs/heads/master@{#31098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -35 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +26 lines, -26 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +21 lines, -7 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-02 22:49:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384483004/1
5 years, 2 months ago (2015-10-02 22:50:26 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 23:13:13 UTC) #5
michael_dawson
On 2015/10/02 23:13:13, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-05 13:26:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384483004/1
5 years, 2 months ago (2015-10-05 13:39:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 14:03:46 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:04:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f940f4358a09193d2869baf03cc88ddcc622bb
Cr-Commit-Position: refs/heads/master@{#31098}

Powered by Google App Engine
This is Rietveld 408576698