Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 1384463002: Componentize proxy_policy_handler from chrome/browser/net (Closed)

Created:
5 years, 2 months ago by Abhishek
Modified:
5 years, 2 months ago
CC:
blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, droger+watchlist_chromium.org, r.kasibhatla, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize proxy_policy_handler from chrome/browser/net Updated gyp and gn build. Added proxy_config in DEPS. BUG=516714 Committed: https://crrev.com/49d1d6354eeec0eed524cde21ab49991aa6d534d Cr-Commit-Position: refs/heads/master@{#352385}

Patch Set 1 #

Patch Set 2 : Updated failed bot issues #

Patch Set 3 : rebase and updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -768 lines) Patch
M chrome/browser/net/OWNERS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/net/proxy_policy_handler.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/net/proxy_policy_handler.cc View 1 chunk +0 lines, -338 lines 0 comments Download
D chrome/browser/net/proxy_policy_handler_unittest.cc View 1 chunk +0 lines, -354 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/core/browser/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M components/policy/core/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/policy/core/browser/proxy_policy_handler.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/browser/proxy_policy_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + components/policy/core/browser/proxy_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/policy_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (11 generated)
Abhishek
PTAL!
5 years, 2 months ago (2015-10-01 09:23:05 UTC) #2
sdefresne
You've got patch failure, can you rebase?
5 years, 2 months ago (2015-10-01 09:31:09 UTC) #3
sdefresne
On 2015/10/01 at 09:31:09, sdefresne wrote: > You've got patch failure, can you rebase? Ah, ...
5 years, 2 months ago (2015-10-01 09:35:18 UTC) #4
droger
LGTM +atwilson I think atwilson is a good OWNER for this CL.
5 years, 2 months ago (2015-10-01 13:06:31 UTC) #6
Andrew T Wilson (Slow)
lgtm
5 years, 2 months ago (2015-10-01 13:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384463002/20001
5 years, 2 months ago (2015-10-01 14:26:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/105660)
5 years, 2 months ago (2015-10-01 14:35:28 UTC) #12
droger
+stevenjb for new dependency on proxy_config. I don't understand why there are OWNERS check failures ...
5 years, 2 months ago (2015-10-01 15:36:59 UTC) #14
stevenjb
owner lgtm
5 years, 2 months ago (2015-10-01 15:38:54 UTC) #15
Abhishek
On 2015/10/01 15:36:59, droger wrote: > +stevenjb for new dependency on proxy_config. > > I ...
5 years, 2 months ago (2015-10-04 12:13:04 UTC) #16
Abhishek
Updated c/b/n/OWNERS file. PTAL!
5 years, 2 months ago (2015-10-04 12:22:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384463002/40001
5 years, 2 months ago (2015-10-04 15:36:27 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/106530)
5 years, 2 months ago (2015-10-04 15:43:54 UTC) #22
Abhishek
+jochen for c/b/n/OWNERS PTAL!
5 years, 2 months ago (2015-10-05 06:14:34 UTC) #24
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-05 15:17:39 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384463002/40001
5 years, 2 months ago (2015-10-05 17:45:52 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-05 19:26:47 UTC) #28
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 19:27:45 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49d1d6354eeec0eed524cde21ab49991aa6d534d
Cr-Commit-Position: refs/heads/master@{#352385}

Powered by Google App Engine
This is Rietveld 408576698