Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1384453005: Add DCHECK_GT macro. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add DCHECK_GT macro. R=ulan@chromium.org BUG= Committed: https://crrev.com/3e19476f28f3c86fa48fe4bf945def41f6cd0cf8 Cr-Commit-Position: refs/heads/master@{#31071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/base/logging.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Lippautz
PTAL
5 years, 2 months ago (2015-10-01 16:51:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384453005/1
5 years, 2 months ago (2015-10-01 16:54:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 17:19:22 UTC) #5
ulan
lgtm
5 years, 2 months ago (2015-10-02 12:06:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384453005/1
5 years, 2 months ago (2015-10-02 12:07:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 12:08:50 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 12:08:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e19476f28f3c86fa48fe4bf945def41f6cd0cf8
Cr-Commit-Position: refs/heads/master@{#31071}

Powered by Google App Engine
This is Rietveld 408576698