Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: PRESUBMIT.py

Issue 1384453004: Resolve TODOs in PRESUBMIT.py (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Initial upload Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 5d0d6bbe8c28645fba0bd31ca1f439df0415e541..e589a47e5b5dfe81ce4f17e6163d99b07a0125a2 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -244,20 +244,11 @@ def _CheckOwnerIsInAuthorsFile(input_api, output_api):
# Found a match, the user is in the AUTHORS file break out of the loop
break
else:
- # TODO(rmistry): Remove the below CLA messaging once a CLA checker has
- # been added to the CQ.
rmistry 2015/10/01 15:01:38 The CQ now fails if CLA has not been signed.
results.append(
output_api.PresubmitError(
'The email %s is not in Skia\'s AUTHORS file.\n'
'Issue owner, this CL must include an addition to the Skia AUTHORS '
- 'file.\n'
- 'Googler reviewers, please check that the AUTHORS entry '
- 'corresponds to an email address in http://goto/cla-signers. If it '
- 'does not then ask the issue owner to sign the CLA at '
- 'https://developers.google.com/open-source/cla/individual '
- '(individual) or '
- 'https://developers.google.com/open-source/cla/corporate '
- '(corporate).'
+ 'file.'
% owner_email))
except IOError:
# Do not fail if authors file cannot be found.
@@ -297,10 +288,7 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
# It is a revert CL, ignore the public api owners check.
return results
- # TODO(rmistry): Stop checking for COMMIT=false once crbug/470609 is
- # resolved.
rmistry 2015/10/01 15:01:38 I resolved this bug.
- if issue_properties['cq_dry_run'] or re.search(
- r'^COMMIT=false$', issue_properties['description'], re.M):
+ if issue_properties['cq_dry_run']:
# Ignore public api owners check for dry run CLs since they are not
# going to be committed.
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698