Issue 1384453004: Resolve TODOs in PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1384453004: Resolve TODOs in PRESUBMIT.py (Closed)

Created:
5 years, 2 months ago by rmistry

Modified:
5 years, 2 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Resolve TODOs in PRESUBMIT.py BUG=skia: Committed: https://skia.googlesource.com/skia/+/9806d4ded5b1a063e3997750127bad22de60607a

Patch Set 1 : Initial upload #

Total comments: 2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -14 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+2 lines, -14 lines	2 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmistry

https://codereview.chromium.org/1384453004/diff/1/PRESUBMIT.py File PRESUBMIT.py (left): https://codereview.chromium.org/1384453004/diff/1/PRESUBMIT.py#oldcode248 PRESUBMIT.py:248: # been added to the CQ. The CQ now ...

5 years, 2 months ago (2015-10-01 15:01:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384453004/1

5 years, 2 months ago (2015-10-01 15:04:12 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-01 15:10:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9806d4ded5b1a063e3997750127bad22de60607a

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages