Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1384453003: MIPS: Pass -fp32 flag to the compiler when building for loongson (Closed)

Created:
5 years, 2 months ago by Djordje.Pesic
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Pass -fp32 flag to the compiler when building for loongson BUG= Committed: https://crrev.com/d36667b391c3d37d90d1414e5a4b2353d59fb2b4 Cr-Commit-Position: refs/heads/master@{#31065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
paul.l...
nit: please edit commit message to change 'Forcing' to 'Pass'.
5 years, 2 months ago (2015-10-01 13:56:32 UTC) #2
Djordje.Pesic
On 2015/10/01 13:56:32, paul.l... wrote: > nit: please edit commit message to change 'Forcing' to ...
5 years, 2 months ago (2015-10-01 13:57:54 UTC) #3
paul.l...
LGTM, could one of you guys PTAL?
5 years, 2 months ago (2015-10-02 05:00:16 UTC) #5
Michael Achenbach
lgtm - rubberstamp
5 years, 2 months ago (2015-10-02 06:38:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384453003/1
5 years, 2 months ago (2015-10-02 07:10:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 07:31:57 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 07:32:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d36667b391c3d37d90d1414e5a4b2353d59fb2b4
Cr-Commit-Position: refs/heads/master@{#31065}

Powered by Google App Engine
This is Rietveld 408576698