Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1384443003: Removing pneubeck@ from OWNERS. (Closed)

Created:
5 years, 2 months ago by pneubeck (no reviews)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing pneubeck@ from OWNERS. Also adding some other overdue owners. Committed: https://crrev.com/d9d909b84f23bdc902917469e347b652f003dbe1 Cr-Commit-Position: refs/heads/master@{#352825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -40 lines) Patch
M chrome/browser/chromeos/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/certificate_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/certificate_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_device_attributes/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/vpn_provider/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/enterprise_platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/certificate_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/enterprise_device_attributes/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/enterprise_platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/networking_config/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/platform_keys/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/vpn_provider/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/tools/onc_validator/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M components/OWNERS View 2 chunks +2 lines, -3 lines 0 comments Download
M components/onc/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/proxy_config/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/networking_config/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/vpn_provider/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/api/vpn_provider/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
pneubeck (no reviews)
Christoph and Maksim, please take a look at all files. blundell@chromium.org: Please review changes in ...
5 years, 2 months ago (2015-10-01 09:55:54 UTC) #2
blundell
//components lgtm Good luck!
5 years, 2 months ago (2015-10-01 09:57:30 UTC) #3
emaxx
lgtm
5 years, 2 months ago (2015-10-01 14:42:24 UTC) #4
stevenjb
Thanks for ensuring there are other owners for these. lgtm.
5 years, 2 months ago (2015-10-01 15:41:03 UTC) #5
Alexei Svitkine (slow)
histograms lgtm
5 years, 2 months ago (2015-10-01 16:24:59 UTC) #6
not at google - send to devlin
+1 thanks for finding replacement owners. lgtm.
5 years, 2 months ago (2015-10-02 00:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384443003/1
5 years, 2 months ago (2015-10-02 16:22:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/106199)
5 years, 2 months ago (2015-10-02 16:35:01 UTC) #11
pneubeck (no reviews)
Drew, I need your lgtm as well
5 years, 2 months ago (2015-10-06 13:16:57 UTC) #13
Andrew T Wilson (Slow)
lgtm
5 years, 2 months ago (2015-10-07 10:28:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384443003/1
5 years, 2 months ago (2015-10-07 11:38:03 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 12:56:30 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 12:57:38 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d909b84f23bdc902917469e347b652f003dbe1
Cr-Commit-Position: refs/heads/master@{#352825}

Powered by Google App Engine
This is Rietveld 408576698