[es6] Fix missing bits for full @@toPrimitive support.

[es6] Fix missing bits for full @@toPrimitive support.

Introduce %_ToNumber intrinsic, which just calls to the existing
ToNumberStub, and remove all uses of our custom JavaScript plus
intrinsics based ToNumber and friends.

Also replace the TO_NUMBER_INLINE macro with TO_NUMBER,
which is currently a wrapper for %_ToNumber. Newly written JS
code should use TO_NUMBER (similar to TO_STRING, TO_INT32,
and friends).

Also finally remove the DefaultString/DefaultNumber builtins, which
are basically the ES5 version of ToPrimitive. Now all code uses the
ES6 version, which is implemented in Object::ToPrimitive and
JSReceiver::ToPrimitive in C++.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
R=jarin@chromium.org
BUG=v8:4307
LOG=n

Committed: https://crrev.com/2a0759d3ff80abd444a70af60d447de18065da30
Cr-Commit-Position: refs/heads/master@{#31054}

[Benedikt Meurer, 2015-10-01 08:24:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 08:24:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384443002/1

[commit-bot: I haz the power, 2015-10-01 08:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 08:26:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/10212)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8562)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10127)

[Benedikt Meurer, 2015-10-01 11:31:26]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 11:31:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384443002/20001

[commit-bot: I haz the power, 2015-10-01 11:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 11:42:41]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Benedikt Meurer, 2015-10-01 11:44:09]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 11:44:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384443002/40001

[commit-bot: I haz the power, 2015-10-01 12:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 12:57:39]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2015-10-01 13:05:47]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-10-01 13:05:48]

Hey Jaro,

Here's the final refactoring for full @@toPrimitive support. Mostly
straightfoward (we need the %_ToNumber to not tank on existing benchmarks).
Please take a look.

Thanks,
Benedikt

https://codereview.chromium.org/1384443002/diff/40001/test/cctest/compiler/te...
File test/cctest/compiler/test-run-jscalls.cc (left):

https://codereview.chromium.org/1384443002/diff/40001/test/cctest/compiler/te...
test/cctest/compiler/test-run-jscalls.cc:144: TEST(RuntimeCallJS) {
Note: There are no "meaningful high level" JS intrinsics left, so I'm kicking
this test.

https://codereview.chromium.org/1384443002/diff/40001/test/mjsunit/compiler/j...
File test/mjsunit/compiler/jsnatives.js (left):

https://codereview.chromium.org/1384443002/diff/40001/test/mjsunit/compiler/j...
test/mjsunit/compiler/jsnatives.js:32: assertEquals(1, %to_number_fun("1"));
Note: There are no "meaningful high level" JS intrinsics left, so I'm kicking
this test.

[Jarin, 2015-10-01 13:22:28]

lgtm. 

It is unfortunate that we need to implement EmitToNumber in platform specific
files. Perhaps we should have a platform specific way to call a 1-argument stub
and then use that in the platform independent full-codegen.cc to implement
EmitToNumber, EmitToString and EmitToObject.

[Benedikt Meurer, 2015-10-01 16:04:52]

On 2015/10/01 13:22:28, Jarin wrote:
> lgtm. 
> 
> It is unfortunate that we need to implement EmitToNumber in platform specific
> files. Perhaps we should have a platform specific way to call a 1-argument
stub
> and then use that in the platform independent full-codegen.cc to implement
> EmitToNumber, EmitToString and EmitToObject.

Yeah, same for %_ToString. Follow-up CL :-)

[Benedikt Meurer, 2015-10-01 16:05:01]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-10-01 16:05:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384443002/40001

[commit-bot: I haz the power, 2015-10-01 16:08:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-01 16:09:00]

Patchset 3 (id:??) landed as
https://crrev.com/2a0759d3ff80abd444a70af60d447de18065da30
Cr-Commit-Position: refs/heads/master@{#31054}