Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138443013: Remove iframe@seamless (Closed)

Created:
6 years, 11 months ago by abarth-chromium
Modified:
6 years, 10 months ago
CC:
blink-reviews, arv+blink, aboxhall, zoltan1, gavinp+loader_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, dsinclair, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove iframe@seamless This CL removes support for seamless iframes. Seamless iframes were already behind a runtime flag, which means this CL doesn't have any web exposed effects. Hopefully someday we'll return to iframe@seamless, but we're currently investing our efforts elsewhere. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165781

Patch Set 1 #

Patch Set 2 : Include remove tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1703 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/css-cascade-child.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/done.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/nested-seamless.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/percent-square.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/quirks-square.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/span.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/frames/seamless/resources/square.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/frames/seamless/resources/two-inline-blocks.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-basic.html View 1 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-basic-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-body-margin.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-body-margin-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-border-padding.html View 1 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-border-padding-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-css-cascade.html View 1 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-css-cascade-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-custom-font-pruning-crash.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-designMode.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-designMode-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-document-write.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-document-write-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-float.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-float-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get-named.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get-named-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get-override.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-get-override-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post-named.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post-named-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post-override.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-form-post-override-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink-named.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink-named-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink-override.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-hyperlink-override-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inherited-document-style.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inherited-document-style-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inherited-origin.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inherited-origin-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inline.html View 1 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-inline-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-min-max.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-min-max-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-nested.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-nested-crash.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-nested-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-nested-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-percent-height.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-percent-height-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-quirks.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-quirks-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-resize-event-hang.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-resize-event-hang-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-sandbox-flag.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-sandbox-flag-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-sandbox-srcdoc.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-srcdoc.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-srcdoc-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-href.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-href-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-replace.html View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-replace-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-sandbox.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-location-sandbox-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-open.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-open-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-open-override.html View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/frames/seamless/seamless-window-open-override-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/multicol/seamless-flowed-through-columns.html View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/multicol/seamless-flowed-through-columns-expected.html View 1 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/http/tests/security/seamless/resources/square.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/security/seamless/seamless-cross-origin.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/http/tests/security/seamless/seamless-cross-origin-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/security/seamless/seamless-sandbox-srcdoc.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 6 chunks +6 lines, -10 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/html.css View 2 chunks +1 line, -9 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +4 lines, -17 lines 0 comments Download
M Source/core/dom/Document.h View 4 chunks +0 lines, -9 lines 0 comments Download
M Source/core/dom/Document.cpp View 10 chunks +2 lines, -65 lines 0 comments Download
M Source/core/dom/DocumentInit.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/dom/SandboxFlags.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 5 chunks +7 lines, -22 lines 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 3 chunks +4 lines, -16 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderIFrame.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 2 chunks +5 lines, -65 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 3 chunks +4 lines, -56 lines 1 comment Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
abarth-chromium
I'll upload a separate CL to remove the tests so that this CL is actually ...
6 years, 11 months ago (2014-01-24 17:52:57 UTC) #1
abarth-chromium
I added all the tests to this CL. Hopefully it's not too hard to review.
6 years, 11 months ago (2014-01-24 18:08:57 UTC) #2
eseidel
Historically seamless leaned heavily on the frame flattening implementation. It looks like that's being left ...
6 years, 11 months ago (2014-01-24 18:25:37 UTC) #3
abarth-chromium
On 2014/01/24 18:25:37, eseidel wrote: > Historically seamless leaned heavily on the frame flattening implementation. ...
6 years, 11 months ago (2014-01-24 18:32:39 UTC) #4
esprehn
lgtm, wow, this is way more complexity than I thought was for this feature.
6 years, 11 months ago (2014-01-24 19:03:32 UTC) #5
Mike West
On 2014/01/24 18:32:39, abarth wrote: > On 2014/01/24 18:25:37, eseidel wrote: > > Historically seamless ...
6 years, 11 months ago (2014-01-24 19:05:54 UTC) #6
abarth-chromium
Done: https://code.google.com/p/chromium/issues/detail?id=337918
6 years, 11 months ago (2014-01-24 21:07:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/138443013/40001
6 years, 11 months ago (2014-01-24 21:07:48 UTC) #8
commit-bot: I haz the power
Change committed as 165781
6 years, 11 months ago (2014-01-24 22:08:40 UTC) #9
eseidel
https://codereview.chromium.org/138443013/diff/40001/Source/core/rendering/RenderView.cpp File Source/core/rendering/RenderView.cpp (left): https://codereview.chromium.org/138443013/diff/40001/Source/core/rendering/RenderView.cpp#oldcode203 Source/core/rendering/RenderView.cpp:203: void RenderView::addChild(RenderObject* newChild, RenderObject* beforeChild) This whole method can ...
6 years, 11 months ago (2014-01-25 02:07:03 UTC) #10
jamesr
This patch deleted the following entries from html.css: iframe:not([seamless]) { border: 2px inset; } iframe[seamless] ...
6 years, 10 months ago (2014-02-13 21:03:40 UTC) #11
eseidel
We can't remove the border on non-seamless iframes. :) I'm surprised that wasn't caught by ...
6 years, 10 months ago (2014-02-13 21:04:51 UTC) #12
jamesr
I think you misunderstand - we still have the border on all iframes, but prior ...
6 years, 10 months ago (2014-02-13 22:15:56 UTC) #13
abarth-chromium
6 years, 10 months ago (2014-02-14 03:05:56 UTC) #14
Message was sent while issue was closed. 
On 2014/02/13 22:15:56, jamesr wrote:
> I think you misunderstand - we still have the border on all iframes, but prior
> to this patch we did *not* have any border on iframe[seamless].  The HTML spec
> requests that UAs have this.  I don't think this is a really big issue, but it
> does mean that the styling for pages that added the seamless attribute due to
> accident/ignorance/whatever will render differently now.

IMHO, it's better to remove all support for the attribute rather than have only
the styling information.  That's consistent with how other user agents that
don't know about seamless act.

Powered by Google App Engine
This is Rietveld 408576698