Issue 138443012: Reland ArrayPop / ArrayPush.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138443012: Reland ArrayPop / ArrayPush. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest

Modified:
6 years, 11 months ago

Reviewers:
mvstanton, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -372 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+0 lines, -73 lines	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+84 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -70 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View		1 chunk	+0 lines, -72 lines	0 comments	Download
M	src/stub-cache.h	View		2 chunks	+0 lines, -17 lines	0 comments	Download
M	src/stub-cache.cc	View		3 chunks	+0 lines, -57 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+0 lines, -71 lines	0 comments	Download
M	test/mjsunit/array-pop.js	View	1 2 3	2 chunks	+17 lines, -0 lines	0 comments	Download
M	test/mjsunit/object-seal.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
A +	test/mjsunit/regress/regress-array-pop-deopt.js	View		1 chunk	+9 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

PTAL. Patch 1 is reupload of the CLs you revert. The fix and test were ...

6 years, 11 months ago (2014-01-24 11:05:05 UTC) #1

mvstanton

It looks okay...I have learned a few things about simulates in this issue! :p lgtm.

6 years, 11 months ago (2014-01-24 11:42:31 UTC) #2

Toon Verwaest

6 years, 11 months ago (2014-01-24 11:48:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r18814 (presubmit successful).